feat: make redux and react-redux truly optional#768
Draft
adamstankiewicz wants to merge 2 commits intoopenedx:masterfrom
Draft
feat: make redux and react-redux truly optional#768adamstankiewicz wants to merge 2 commits intoopenedx:masterfrom
adamstankiewicz wants to merge 2 commits intoopenedx:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 83.36% 83.13% -0.23%
==========================================
Files 40 40
Lines 1070 1091 +21
Branches 200 201 +1
==========================================
+ Hits 892 907 +15
- Misses 166 172 +6
Partials 12 12 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
commented
Feb 21, 2025
src/react/AppProvider.test.jsx
Outdated
| }); | ||
|
|
||
| it('should render its children with a router', async () => { | ||
| it('should render its children with a router', () => { |
Member
Author
There was a problem hiding this comment.
[inform] Needing to make these tests async was a clue that the previous approach with React.lazy was technically a breaking change for consuming MFEs' tests.
Also, note, I believe using React.lazy here would have prevented the component from being able to get rendered with SSR, as React.lazy depends on dynamic runtime imports. Using a dynamic import within a useEffect appears to be compatible with SSR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
#766
Per this comment, this PR reintroduces the changes to make the
reduxandreact-reduxpeer dependencies optional.Merge checklist:
frontend-platform. This can be done by runningnpm startand opening http://localhost:8080.module.config.jsfile infrontend-build.fix,feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: